chore(deps): upgrade to celestia-app v2.0.0-rc2 #3453
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
renaynay
added
v0.15.0
rootulp
commented
Jun 6, 2024
| NamespaceId: namespace.ID(), | ||
| Data: data, | ||
| ShareVersion: uint32(shareVersion), | ||
| NamespaceVersion: uint32(namespace.Version()), | ||
| } | ||
|
|
||
| com, err := types.CreateCommitment(&blob) | ||
| com, err := inclusion.CreateCommitment(&blob, merkle.HashFromByteSlices, appconsts.SubtreeRootThreshold(v1.Version)) |
There was a problem hiding this comment.
[for reviewers] Invoking with v1.Version behaves identically to invoking with v2.Version because the implementation of this function doesn't actually care about the version that is provided as an argument.
rootulp
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss,
ramin and
cristaloleg
as code owners
blob/blobtest/testing.go:31:25: copylocks: call of append copies lock value: github.com/celestiaorg/go-square/blob.Blob contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
blobs = append(blobs, *appBlob)
This comment was marked as outdated.
This comment was marked as outdated.
There's a TODO that states celestia-app isn't set up. The assertion fails because the min gas price returned is "" even though the app config attempts to set it to .002
because it doesn't appear to be compiled based on build flags
…custom chain-ids" This reverts commit a5650ac.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
|
|
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update celestia-node to use celestia-app v2.0.0-rc2. A few changes that were needed:
CreateCommitment. celestia-app v2.x usesCreateCommitmentfrom the go-square inclusion package.header.Version.App = 2. Added unit tests.signer. celestia-app v2.x split atxClientfrom thesigner. See: feat: add multi-account support celestia-app#3433I had to updatecore_access.goa lot. Mostly inspired by feat: support multiple accounts #3451Testing
I ran a script with: celestia-app v2.0.0-rc2 and configured it to upgrade at block height 3. celestia-node (built from this PR) continued to work: